linux-kernel - Re: [PATCH] ASoC: rsnd: make some arrays static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877dh4yd45.wl-kuninori.morimoto.gx@renesas.com>
Date:   02 Aug 2021 08:11:22 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: rsnd: make some arrays static const, makes object smaller


Hi Colin

Thank you for your patch

> Don't populate arrays on the stack but instead them static const.
> Makes the object code smaller by 242 bytes.
> 
> Before:
>    text    data     bss     dec     hex filename
>   23827    8764       0   32591    7f4f ./sound/soc/sh/rcar/ssi.o
> 
> After:
>    text    data     bss     dec     hex filename
>   23361    8988       0   32349    7e5d ./sound/soc/sh/rcar/ssi.o
> 
> gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Nice to know.

	Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

Do you think we need similar patch to below ?
(In my quick check)

	core.c	rsnd_get_busif_shift()
		volume_ramp_rate[] // need static ?
	adg.c	rsnd_adg_clk_query()
		rsnd_adg_get_clkout()

Thank you for your help !!

Best regards
---
Kuninori Morimoto