linux-kernel - Re: [PATCH] dmaengine: usb-dmac: make usb_dmac_get_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQY+5OaQKYeWQ+/n@kroah.com>
Date:   Sun, 1 Aug 2021 08:27:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jordy Zomer <jordy@...ing.systems>
Cc:     dmaengine@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: usb-dmac: make usb_dmac_get_current_residue
 unsigned

On Sat, Jul 31, 2021 at 11:19:38AM +0200, Jordy Zomer wrote:
> The usb_dmac_get_current_residue function used to
> take a signed integer as a pos parameter.
> The only callers of this function passes an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
> 
> Signed-off-by: Jordy Zomer <jordy@...ing.systems>
> ---
>  drivers/dma/sh/usb-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/sh/usb-dmac.c b/drivers/dma/sh/usb-dmac.c
> index 8f7ceb698226..a5e225c15730 100644
> --- a/drivers/dma/sh/usb-dmac.c
> +++ b/drivers/dma/sh/usb-dmac.c
> @@ -466,7 +466,7 @@ static int usb_dmac_chan_terminate_all(struct dma_chan *chan)
>  
>  static unsigned int usb_dmac_get_current_residue(struct usb_dmac_chan *chan,
>  						 struct usb_dmac_desc *desc,
> -						 int sg_index)
> +						 unsigned int sg_index)
>  {
>  	struct usb_dmac_sg *sg = desc->sg + sg_index;
>  	u32 mem_addr = sg->mem_addr & 0xffffffff;
> -- 
> 2.27.0
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>