linux-kernel - Re: [PATCH] KVM: SEV: improve the code readability for ASID management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL715WJo_sAmnZ170iJ7TenehJcm3KYLLhjyHi8Jw61whUU-zA@mail.gmail.com>
Date:   Mon, 2 Aug 2021 09:00:29 -0700
From:   Mingwei Zhang <mizhang@...gle.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>, kvm <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Marc Orr <marcorr@...gle.com>,
        David Rientjes <rientjes@...gle.com>,
        Alper Gun <alpergun@...gle.com>,
        Dionna Glaze <dionnaglaze@...gle.com>,
        Vipin Sharma <vipinsh@...gle.com>
Subject: Re: [PATCH] KVM: SEV: improve the code readability for ASID management

Right, it does not fix any bugs but improves readability. I will
remove this primitive.

On Mon, Aug 2, 2021 at 6:38 AM Joerg Roedel <joro@...tes.org> wrote:
>
> On Fri, Jul 30, 2021 at 06:13:04PM -0700, Mingwei Zhang wrote:
> > Fix the min_asid usage: ensure that its usage is consistent with its name;
> > adjust its value before using it as a bitmap position. Add comments on ASID
> > bitmap allocation to clarify the skipping-ASID-0 property.
> >
> > Fixes: 80675b3ad45f (KVM: SVM: Update ASID allocation to support SEV-ES guests)
>
> This looks more like an optimization to me, or does this fix any real
> bug?
>