linux-kernel - Re: [PATCH] dmaengine: idxd: Remove unused status variable in irq_process_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d03981eb-67da-55fe-bc82-d83b00a22944@intel.com>
Date:   Mon, 2 Aug 2021 11:02:17 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Nathan Chancellor <nathan@...nel.org>,
        Vinod Koul <vkoul@...nel.org>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Remove unused status variable in
 irq_process_work_list()


On 8/2/2021 10:58 AM, Nathan Chancellor wrote:
> status is no longer used within this block:
>
> drivers/dma/idxd/irq.c:255:6: warning: unused variable 'status'
> [-Wunused-variable]
>                  u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
>                     ^
> 1 warning generated.
>
> Fixes: b60bb6e2bfc1 ("dmaengine: idxd: fix abort status check")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Dave Jiang <dave.jiang@...el.com>

Thanks.


> ---
>   drivers/dma/idxd/irq.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 65dc7bbb0a13..91e46ca3a0ad 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -252,8 +252,6 @@ static int irq_process_work_list(struct idxd_irq_entry *irq_entry,
>   	spin_unlock_irqrestore(&irq_entry->list_lock, flags);
>   
>   	list_for_each_entry(desc, &flist, list) {
> -		u8 status = desc->completion->status & DSA_COMP_STATUS_MASK;
> -
>   		/*
>   		 * Check against the original status as ABORT is software defined
>   		 * and 0xff, which DSA_COMP_STATUS_MASK can mask out.
>
> base-commit: e9c5b0b53ccca81dd0a35c62309e243a57c7959d