linux-kernel - Re: kernel BUG in new r8188eu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Aug 2021 16:38:53 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-staging@...ts.linux.dev
Subject: Re: kernel BUG in new r8188eu

On Mon, Aug 02, 2021 at 01:45:06PM +0200, Fabio M. De Francesco wrote:
> Hi Greg,
> 
> On Monday, August 2, 2021 12:36:18 PM CEST Greg Kroah-Hartman wrote:
> > On Sun, Aug 01, 2021 at 03:15:52PM -0500, Larry Finger wrote:
> > > On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote:
> > > > I am worried that my "remove the wrapper" logic got something wrong
> > > > here, so if you could test the revert of that, I would appreciate it.
> > > > 
> > > > I think I need to go buy one of these devices so I can test cleanups
> > > > locally...
> > > 
> > > The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free()
> > > function").
> > > 
> > > Looking at it, the only difference between the original wrapper and the 
> new
> > > code is that the wrapper zeros the len variable before the kfree() call, 
> but
> > > making that change did not help. Reverting that patch restores the old
> > > behavior.
> > 
> > Ah, doh, that was my fault, sorry, that patch was incorrect (odd git id,
> > don't know where that came from, it's a different id in my tree.)  Let
> > me revert this commit and then will redo it correctly.
> 
> The commit to revert should be c7e88ecbe328.

Yes, thanks, now reverted.

> > thanks for finding this.
> > 
> > > There are lots of these on Ebay from $2.47 up with free shipping!
> > 
> > Any hints on the name for how to figure out which devices are supported
> > by this driver?
> 
> The following link points to a device that seems to be supported by this 
> driver. It is just $4.99, but I'm not sure whether or not they ship to Europe 
> (I suppose you're here):
> 
> https://www.amazon.com/gp/product/B00L28AN88/ref=ox_sc_act_title_1

Yeah, I'm in Europe, I'll try to find something within the EU to avoid
the mess with importing electronics and duties.  It's a mess everytime I
do that...

> About this item: 
> * Chipset:RTL8188EU 
> * Standard: IEEE 802.11n,IEEE 802.11g, IEEE 802.11b 
> * Supports 64/128 bit WEP, WPA encryption 
> 
> Otherwise, I think that the following uses the same chip as the above. 
> However, it costs a little more and, above all else, I'm not really sure if it 
> works with r8188eu, since they write that the chip is a Realtek RTL8188EUS 
> (please note that final "EUS"):
> 
> https://www.amazon.it/Asus-USB-N10-NANO-N150-compatibile/dp/B081758CWC/
> ref=sr_1_1

Yeah, I found a bunch of "EUS" devices here, will keep digging.

thanks,

greg k-h