linux-kernel - Re: [PATCH 2/3] spi: modify set_cs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210802201614.GA39900@sirena.org.uk>
Date:   Mon, 2 Aug 2021 21:16:14 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Mason Zhang <mason.zhang@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        leilk.liu@...iatek.com, wsd_upstream@...iatek.com
Subject: Re: [PATCH 2/3] spi: modify set_cs_timing parameter

On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@...iatek.com>
> 
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
  master->set_cs_timing = tegra_spi_set_hw_cs_timing;
                        ^

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)