linux-kernel - Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210802133230.1a17ac4c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 2 Aug 2021 13:32:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Joakim Zhang <qiangqing.zhang@....com>
Cc:     davem@...emloft.net, andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work

On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
>  		fep->phy_interface = interface;
>  	}
>  
> +	ret = fec_enet_parse_rgmii_delay(fep, np);
> +	if (ret)
> +		goto failed_phy;

You're jumping to the wrong label, it looks like phy_node needs to be
released at this point.