linux-kernel - [PATCH] sound: usb: get lock before calling usb_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 2 Aug 2021 23:53:39 +0100
From:   Salah Triki <salah.triki@...il.com>
To:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Pavel Skripkin <paskripkin@...il.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Mark Brown <broonie@...nel.org>, Joe Perches <joe@...ches.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sound: usb: get lock before calling  usb_enable_autosuspend()

Based on the documentation of usb_enable_autosuspend(), the
caller must hold udev's device lock.

Signed-off-by: Salah Triki <salah.triki@...il.com>
---
 sound/usb/card.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/sound/usb/card.c b/sound/usb/card.c
index 2f6a62416c05..9290ba0acd5f 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -907,8 +907,13 @@ static void usb_audio_disconnect(struct usb_interface *intf)
 		}
 	}
 
-	if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND)
-		usb_enable_autosuspend(interface_to_usbdev(intf));
+	if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND) {
+		struct usb_device *udev = interface_to_usbdev(intf);
+
+		usb_lock_device(udev);
+		usb_enable_autosuspend(udev);
+		usb_unlock_device(udev);
+	}
 
 	chip->num_interfaces--;
 	if (chip->num_interfaces <= 0) {
-- 
2.25.1