linux-kernel - Re: [PATCH v3 3/3] KVM: x86/mmu: Add detailed page size stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL715WJ1=ZA+0hBzCfUQBvvuN_++iQG1wc=JKfmpq-iUnDxkVA@mail.gmail.com>
Date:   Mon, 2 Aug 2021 16:45:53 -0700
From:   Mingwei Zhang <mizhang@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm <kvm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ben Gardon <bgardon@...gle.com>,
        Jing Zhang <jingzhangos@...gle.com>,
        David Matlack <dmatlack@...gle.com>
Subject: Re: [PATCH v3 3/3] KVM: x86/mmu: Add detailed page size stats

>
> Looks good, but you'll probably need/want to rebase to kvm/queue once that settles
> down (I suspect a forced push is coming this week).  This has quite a few conflicts
> with other stuff sitting in kvm/queue.

will do.

> > @@ -235,9 +235,12 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = {
> >       STATS_DESC_COUNTER(VM, mmu_recycled),
> >       STATS_DESC_COUNTER(VM, mmu_cache_miss),
> >       STATS_DESC_ICOUNTER(VM, mmu_unsync),
> > -     STATS_DESC_ICOUNTER(VM, lpages),
> >       STATS_DESC_ICOUNTER(VM, nx_lpage_splits),
> > -     STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions)
> > +     STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions),
> > +     STATS_DESC_ICOUNTER(VM, pages_4k),
> > +     STATS_DESC_ICOUNTER(VM, pages_2m),
> > +     STATS_DESC_ICOUNTER(VM, pages_1g),
> > +     STATS_DESC_ICOUNTER(VM, pages_512g)
>
> Uber nit that I wouldn't even have noticed if this didn't conflict, but there's
> no need to land the union and the stats definitions at the end of the structs,
> i.e. the new fields can directly replace lpages.  I don't think it will actually
> avoid a conflict, but it would avoid modifying the max_mmu_page_hash_collisions
> line.
>

ah, so I will just remove 'lpages' and put new lines in place instead
appending those at the end. Yeah, I did not know that it can create
conflicts. So, I will change that.