linux-kernel - Re: [PATCH] sched/rt: Fix double enqueue caused by rt_effective

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQegVmIoVGOjt4w+@localhost.localdomain>
Date:   Mon, 2 Aug 2021 09:35:50 +0200
From:   Juri Lelli <juri.lelli@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org,
        vincent.guittot@...aro.org, rostedt@...dmis.org,
        dietmar.eggemann@....com, bristot@...hat.com, bsegall@...gle.com,
        mgorman@...e.de, Mark Simmons <msimmons@...hat.com>
Subject: Re: [PATCH] sched/rt: Fix double enqueue caused by rt_effective_prio

Hi Peter,

On 09/07/21 10:33, Juri Lelli wrote:
> Hi Peter,
> 
> On 08/07/21 12:26, Peter Zijlstra wrote:
> > On Thu, Jul 08, 2021 at 12:06:27PM +0200, Peter Zijlstra wrote:
> > > Slightly larger patch, but perhaps a little cleaner.. still pondering if
> > > we can share a little more between __sched_setscheduler() and
> > > rt_mutex_setprio().
> > 
> > Best I can seem to come up with...
> 
> Thanks for the non-lazy version of the fix!
> 
> Makes sense to me and it looks good from quick testing. I'll be doing
> more extensive testing and ask Mark (cc-ed) to help with that. :)
> 
> We'll report back soon-ish.

So, yeah it took a while (mostly my pto :), apologies.

However, we managed to confirm your fix works great!

May I leave posting it again with changelog etc to you, or would you
like I do that (making you the author)?

Thanks,
Juri