linux-kernel - Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQezqZcOrePV/FnW@archbook>
Date:   Mon, 2 Aug 2021 01:58:17 -0700
From:   Moritz Fischer <mdf@...nel.org>
To:     kajoljain <kjain@...ux.ibm.com>
Cc:     will@...nel.org, hao.wu@...el.com, mark.rutland@....com,
        trix@...hat.com, yilun.xu@...el.com, mdf@...nel.org,
        linux-fpga@...r.kernel.org, maddy@...ux.ibm.com,
        atrajeev@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, rnsastry@...ux.ibm.com,
        linux-perf-users@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance
 reporting

On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote:
> 
> 
> On 7/13/21 1:12 PM, Kajol Jain wrote:
> > The performance reporting driver added cpu hotplug
> > feature but it didn't add pmu migration call in cpu
> > offline function.
> > This can create an issue incase the current designated
> > cpu being used to collect fme pmu data got offline,
> > as based on current code we are not migrating fme pmu to
> > new target cpu. Because of that perf will still try to
> > fetch data from that offline cpu and hence we will not
> > get counter data.
> > 
> > Patch fixed this issue by adding pmu_migrate_context call
> > in fme_perf_offline_cpu function.
> > 
> > Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support")
> > Tested-by: Xu Yilun <yilun.xu@...el.com>
> > Acked-by: Wu Hao <hao.wu@...el.com>
> > Signed-off-by: Kajol Jain <kjain@...ux.ibm.com>
> > Cc: stable@...r.kernel.org
> > ---
> 
> Any update on this patch? Please let me know if any changes required.
> 
> Thanks,
> Kajol Jain

It's in my 'fixes' branch.

- Moritz