linux-kernel - Re: [PATCH] mm: slub: Fix slub_debug disablement for list of slabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2d6cbbf-8eaa-3198-9b43-73eb5965fb1f@google.com>
Date:   Sun, 1 Aug 2021 20:26:04 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Vlastimil Babka <vbabka@...e.cz>
cc:     Vijayanand Jitta <vjitta@...eaurora.org>, cl@...ux.com,
        penberg@...nel.org, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, vinmenon@...eaurora.org
Subject: Re: [PATCH] mm: slub: Fix slub_debug disablement for list of slabs

On Tue, 27 Jul 2021, Vlastimil Babka wrote:

> From 81a225fe31e53701902bb4caa9ab1524eb044cbc Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@...e.cz>
> Date: Tue, 13 Jul 2021 17:15:50 +0530
> Subject: [PATCH] mm: slub: fix slub_debug disabling for list of slabs
> 
> Vijayanand Jitta reports:
> 
>   Consider the scenario where CONFIG_SLUB_DEBUG_ON is set
>   and we would want to disable slub_debug for few slabs.
>   Using boot parameter with slub_debug=-,slab_name syntax
>   doesn't work as expected i.e; only disabling debugging for
>   the specified list of slabs. Instead it disables debugging
>   for all slabs, which is wrong.
> 
> This patch fixes it by delaying the moment when the global slub_debug flags
> variable is updated. In case a "slub_debug=-,slab_name" has been passed, the
> global flags remain as initialized (depending on CONFIG_SLUB_DEBUG_ON enabled
> or disabled) and are not simply reset to 0.
> 
> Reported-by: Vijayanand Jitta <vjitta@...eaurora.org>
> Signed-off-by: Vlastimil Babka <vbabka@...e.cz>
> Reviewed-by: Vijayanand Jitta <vjitta@...eaurora.org>

Acked-by: David Rientjes <rientjes@...gle.com>

Looks better, thanks!