linux-kernel - Re: [PATCH] kernel/auditsc: remove unused header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhRubqCjzv54VSQg5cmAm+G7hBNO=72Eb3-EcbGCtn3_dg@mail.gmail.com>
Date:   Mon, 2 Aug 2021 09:54:23 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Hui Su <suhui@...u.com>
Cc:     Eric Paris <eparis@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/auditsc: remove unused header file

On Fri, Jul 30, 2021 at 3:52 AM Hui Su <suhui@...u.com> wrote:
>
> Since commit c72051d5778a ("audit: use ktime_get_coarse_ts64()
> for time access"), the linux/time.h is unused.
>
> Signed-off-by: Hui Su <suhui@...u.com>
> ---
>  kernel/auditsc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 8dd73a64f921..33bb6a83baf1 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -57,7 +57,6 @@
>  #include <linux/mqueue.h>
>  #include <linux/audit.h>
>  #include <linux/personality.h>
> -#include <linux/time.h>
>  #include <linux/netlink.h>
>  #include <linux/compiler.h>
>  #include <asm/unistd.h>

At the very least the kernel/auditsc.c file still makes use of the
timespec64 struct which is defined in include/linux/time64.h which is
brought in by include/linux/time.h and *not* by
include/linux/timekeeping.h.  As long as we make use of the timespec64
struct and the definition remains in time64.h let's keep the time.h
include.

-- 
paul moore
www.paul-moore.com