linux-kernel - Re: [PATCH v4 1/6] iommu: Refactor iommu_group_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210802144621.GB28735@willie-the-truck>
Date:   Mon, 2 Aug 2021 15:46:22 +0100
From:   Will Deacon <will@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     joro@...tes.org, robin.murphy@....com, baolu.lu@...ux.intel.com,
        iommu@...ts.linux-foundation.org, linuxarm@...wei.com,
        thierry.reding@...il.com, airlied@...ux.ie, daniel@...ll.ch,
        jonathanh@...dia.com, sakari.ailus@...ux.intel.com,
        bingbu.cao@...el.com, tian.shu.qiu@...el.com, mchehab@...nel.org,
        gregkh@...uxfoundation.org, digetx@...il.com, mst@...hat.com,
        jasowang@...hat.com, linux-kernel@...r.kernel.org,
        chenxiang66@...ilicon.com
Subject: Re: [PATCH v4 1/6] iommu: Refactor iommu_group_store_type()

On Wed, Jul 14, 2021 at 06:36:38PM +0800, John Garry wrote:
> Function iommu_group_store_type() supports changing the default domain
> of an IOMMU group.
> 
> Many conditions need to be satisfied and steps taken for this action to be
> successful.
> 
> Satisfying these conditions and steps will be required for setting other
> IOMMU group attributes, so factor into a common part and a part specific
> to update the IOMMU group attribute.
> 
> No functional change intended.
> 
> Some code comments are tidied up also.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>  drivers/iommu/iommu.c | 73 +++++++++++++++++++++++++++----------------
>  1 file changed, 46 insertions(+), 27 deletions(-)

Acked-by: Will Deacon <will@...nel.org>

Although likely to conflict with Robin's monster series.

Will