linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <029e9d59-ced7-af14-3e9e-2c7a62671abf@codeaurora.org>
Date:   Tue, 3 Aug 2021 10:03:16 +0530
From:   Rajendra Nayak <rnayak@...eaurora.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>, agross@...nel.org,
        bjorn.andersson@...aro.org, robh+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, skakit@...eaurora.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files
 for IDP2



On 8/2/2021 6:06 PM, Rajendra Nayak wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> index 73225e3..f014cda 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts
>>> @@ -7,19 +7,12 @@
>>>   /dts-v1/;
>>> -#include <dt-bindings/gpio/gpio.h>
>>> -#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
  
I re-read your comment and I guess you meant this ^^^ header include
should stay too, and that's right, I seem to have wrongly moved it
to the common dtsi, will fix when I respost. thanks.

>>> -#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
>>
>> Don't you want pmr735a include to stay here in SKU1 and not be included in the common one, as the hw is not present on sku2?
> []..
>>>   #include "pmr735a.dtsi"
> 
> Right, that's why this ^^^ include stays here and is not part of the common dtsi.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation