linux-kernel - Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling convention of other reset methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210803044929.p22ren6wwl3jff3f@archlinux>
Date:   Tue, 3 Aug 2021 10:19:29 +0530
From:   Amey Narkhede <ameynarkhede03@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, alex.williamson@...hat.com,
        Raphael Norwitz <raphael.norwitz@...anix.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kw@...ux.com, Shanker Donthineni <sdonthineni@...dia.com>,
        Sinan Kaya <okaya@...nel.org>, Len Brown <lenb@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH v13 2/9] PCI: Add pcie_reset_flr to follow calling
 convention of other reset methods

On 21/08/02 05:44PM, Bjorn Helgaas wrote:
> On Sun, Aug 01, 2021 at 07:55:11PM +0530, Amey Narkhede wrote:
> > Currently there is separate function pcie_has_flr() to probe if PCIe FLR
> > is supported by the device which does not match the calling convention
> > followed by reset methods which use second function argument to decide
> > whether to probe or not. Add new function pcie_reset_flr() that follows
> > the calling convention of reset methods.
> >
> > Signed-off-by: Amey Narkhede <ameynarkhede03@...il.com>
> > ---
> >  drivers/crypto/cavium/nitrox/nitrox_main.c |  4 +--
> >  drivers/pci/pci.c                          | 40 +++++++++++++++-------
> >  drivers/pci/pcie/aer.c                     | 12 +++----
> >  drivers/pci/quirks.c                       |  9 ++---
> >  include/linux/pci.h                        |  2 +-
> >  5 files changed, 38 insertions(+), 29 deletions(-)
>
> >  int pcie_flr(struct pci_dev *dev)
> >  {
> > @@ -4655,7 +4653,26 @@ int pcie_flr(struct pci_dev *dev)
> >
> >  	return pci_dev_wait(dev, "FLR", PCIE_RESET_READY_POLL_MS);
> >  }
> > -EXPORT_SYMBOL_GPL(pcie_flr);
> > +EXPORT_SYMBOL(pcie_flr);
>
> Why this change?  If it's unintentional and there's no other reason to
> repost, I can fix it up locally.
Yeah my bad it was unintentional.