linux-kernel - RE: [PATCH v9 25/26] intel_idle/amx: Add SPR support with XTILEDATA capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL0PR11MB35066FED42DA00B3215D8D5EE0F09@BL0PR11MB3506.namprd11.prod.outlook.com>
Date:   Tue, 3 Aug 2021 21:43:11 +0000
From:   "Brown, Len" <len.brown@...el.com>
To:     "Hansen, Dave" <dave.hansen@...el.com>,
        "Bae, Chang Seok" <chang.seok.bae@...el.com>
CC:     Borislav Petkov <bp@...e.de>, "Lutomirski, Andy" <luto@...nel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        "Macieira, Thiago" <thiago.macieira@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [PATCH v9 25/26] intel_idle/amx: Add SPR support with XTILEDATA
 capability

> Also, should this have something like a fpregs_state_valid() check?  If the registers are invalid, should this be calling tile_release()?

From a correctness point of view, it is valid to always call tile_release() here.
From a performance point of view, tile_release() is very fast.