linux-kernel - Re: [PATCH net-next] tc-testing: Add control-plane selftests for sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVUMzP8_gPsth_DncVUdC09ihizTC7jo2t1=MS9uSdfTw@mail.gmail.com>
Date:   Tue, 3 Aug 2021 15:21:15 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Peilin Ye <yepeilin.cs@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Lucas Bates <lucasb@...atatu.com>,
        Cong Wang <cong.wang@...edance.com>,
        Peilin Ye <peilin.ye@...edance.com>
Subject: Re: [PATCH net-next] tc-testing: Add control-plane selftests for sch_mq

On Tue, Aug 3, 2021 at 3:17 PM Peilin Ye <yepeilin.cs@...il.com> wrote:
> +           "setup": [
> +            "echo \"1 1 4\" > /sys/bus/netdevsim/new_device"
> +           ],
> +           "cmdUnderTest": "$TC qdisc add dev $ETH root handle 1: mq",
> +           "expExitCode": "0",
> +           "verifyCmd": "$TC qdisc show dev $ETH",
> +           "matchPattern": "qdisc pfifo_fast 0: parent 1:[1-4] bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1",
> +           "matchCount": "4",
> +           "teardown": [
> +                   "echo \"1\" > /sys/bus/netdevsim/del_device"
> +           ]
> +       },

Like I mentioned to Peilin, I am _not_ sure whether it is better to create
netdevsim device in such a way. Maybe we need to create it before
these tests and pass it via cmdline?? Lucas?

Thanks.