linux-kernel - Re: [PATCH] staging: gdm724x: get lock before calling usb_[disable|enable]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQjRHLpJtvdavYjj@kroah.com>
Date:   Tue, 3 Aug 2021 07:16:12 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Salah Triki <salah.triki@...il.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Amey Narkhede <ameynarkhede03@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm724x: get lock before calling
 usb_[disable|enable]_autosuspend()

On Mon, Aug 02, 2021 at 11:37:03PM +0100, Salah Triki wrote:
> Based on the documentation of usb_[disable|enable]_autosuspend(), the
> caller must hold udev's device lock.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  drivers/staging/gdm724x/gdm_usb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
> index 54bdb64f52e8..31b3b3e563c8 100644
> --- a/drivers/staging/gdm724x/gdm_usb.c
> +++ b/drivers/staging/gdm724x/gdm_usb.c
> @@ -846,7 +846,9 @@ static int gdm_usb_probe(struct usb_interface *intf,
>  	udev->intf = intf;
>  
>  	intf->needs_remote_wakeup = 1;
> +	usb_lock_device(usbdev);
>  	usb_enable_autosuspend(usbdev);
> +	usb_unlock_device(usbdev);
>  	pm_runtime_set_autosuspend_delay(&usbdev->dev, AUTO_SUSPEND_TIMER);
>  
>  	/* List up hosts with big endians, otherwise,
> -- 
> 2.25.1

Please look at the other places where this function is called and note
that the pattern you have added here is not used in those situations
either, so perhaps this change is not correct at all.

thanks,

greg k-h