linux-kernel - Re: [PATCH v2] vhci_hcd: USB port can get stuck in the disabled state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Aug 2021 11:00:10 +1000
From:   Michael <msbroadf@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     valentina.manea.m@...il.com, shuah@...nel.org,
        gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] vhci_hcd: USB port can get stuck in the disabled state

On Tue, 3 Aug 2021 at 09:14, Shuah Khan <skhan@...uxfoundation.org> wrote:
>
> On 7/30/21 5:52 PM, Michael wrote:
> > Yes i think just adding the VDEV_ST_USED check in addition to the
> > VDEV_ST_NOT_ASSIGNED state is fine and would fix the issue.
> >
>
> Can you please confirm if this works?
>
> > After many years of writing virtualhere (a similar system to usb/ip
> > but cross-platform and different non-kernel way of doing it server
> > side) I've seen many drivers that issue reset at any time. Loading
> > firmware is usually the reason.  Also sometimes switching
> > configurations requires a reset also, for example some gaming wheels
> > do this. I don't think you should make this VDEV_ST_USED check
> > specific to Wifi devices, as a lot of devices don't follow too closely
> > to the USB protocol to begin with from my experience. They primarily
> > base their USB interactions assuming the windows platform and its
> > quirks.
> >
>
> When sending responses to Linux kernel mailing lists, please use bottom post.
> This check will be used for all drivers. We don't add checks for specific cases
> in the code.
>
> thanks,
> -- Shuah
>

Yes it works with that change.