linux-kernel - Re: [PATCH v3 7/7] media: venus: Set buffer to FW based on FW min count requirement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <253417f1-579a-0a57-388b-7fb07fd83d9c@linaro.org>
Date:   Tue, 3 Aug 2021 11:00:32 +0300
From:   Stanimir Varbanov <stanimir.varbanov@...aro.org>
To:     dikshita@...eaurora.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, vgarodia@...eaurora.org
Subject: Re: [PATCH v3 7/7] media: venus: Set buffer to FW based on FW min
 count requirement.



On 8/2/21 10:50 AM, dikshita@...eaurora.org wrote:
>>> req->count_min = inst->fw_min_cnt;
>>> +
>>> +    ret = hfi_plat->bufreq(&params, inst->session_type, buftype, req);
>>> +    if (buftype == HFI_BUFFER_OUTPUT || buftype == HFI_BUFFER_OUTPUT2)
>>
>> ^^^^
>>
>>> +        if (inst->fw_min_cnt != req->count_min)
>>> +            inst->fw_min_cnt = req->count_min;
>>> +    return ret;
>>>  }
>>
>> Also in regards to inst->fw_min_cnt, can we pass fw_min_cnt as input to
>> get_bufreq via 'req' structure, i.e.
>>
>> req.count_min = inst->fw_min_cnt;
>>
>> ret = venus_helper_get_bufreq(inst, type, &req);
>>
>> inst->fw_min_cnt = req.count_min
>>
>> ?
>>
> Sorry, I didn't get it, How is this different from the current
> implementation?

The difference is that platform_get_bufreq() will not modify any of
'struct venus_inst' members, i.e. platform_get_bufreq() is not supposed
to change anything from input 'inst' argument.

-- 
regards,
Stan