linux-kernel - Re: [PATCH v1 1/1] x86/PCI: Introduce pcibios_is_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeKvBqi=vhkq0Vqv76t3qKzWmy_v_ZmeL4mbPztmcGb7g@mail.gmail.com>
Date:   Tue, 3 Aug 2021 13:19:05 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci <linux-pci@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] x86/PCI: Introduce pcibios_is_irq_managed() helper

On Tue, Aug 3, 2021 at 2:17 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
> On Fri, Jul 30, 2021 at 11:53:55PM +0300, Andy Shevchenko wrote:

...

> > -     if (!pin || !dev->irq_managed || dev->irq <= 0)
> > +     if (!pin || !pcibios_irq_is_managed(dev))
>
> This file may be compiled for x86, arm64, and ia64, but it looks like
> you only defined pcibios_irq_is_managed() for x86.

Ah, right. Ignore this patch.
Thanks for the review!

-- 
With Best Regards,
Andy Shevchenko