linux-kernel - Re: [PATCH v2] tools: PCI: Zero-initialize param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2017bdfe-b053-0dbe-82e3-b5533dbe372e@gmail.com>
Date:   Tue, 3 Aug 2021 19:48:37 +0800
From:   Shunyong Yang <yang.shunyong@...il.com>
To:     bhelgaas@...gle.com, lorenzo.pieralisi@....com, kw@...ux.com,
        leon@...nel.org, kishon@...com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tools: PCI: Zero-initialize param

Hi, Bjorn,

    Would you please help to review and put this tiny fix (for 
tools/pci/pcitest.c) in your merge queue? Kishon has acked.

Thanks.

Shunyong

On 2021/7/14 21:32, Kishon Vijay Abraham I wrote:
>
> On 14/07/21 6:53 pm, Shunyong Yang wrote:
>> The values in param may be random if they are not initialized, which
>> may cause use_dma flag set even when "-d" option is not provided
>> in command line. Initializing all members to 0 to solve this.
>>
>> Signed-off-by: Shunyong Yang <yang.shunyong@...il.com>
> Thanks for the fix.
>
> Acked-by: Kishon Vijay Abraham I <kishon@...com>
>
>
>> ---
>> v2: Change {0} to {} as Leon Romanovsky's comment.
>> ---
>>   tools/pci/pcitest.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
>> index 0a1344c45213..441b54234635 100644
>> --- a/tools/pci/pcitest.c
>> +++ b/tools/pci/pcitest.c
>> @@ -40,7 +40,7 @@ struct pci_test {
>>   
>>   static int run_test(struct pci_test *test)
>>   {
>> -	struct pci_endpoint_test_xfer_param param;
>> +	struct pci_endpoint_test_xfer_param param = {};
>>   	int ret = -EINVAL;
>>   	int fd;
>>   
>>