linux-kernel - Re: [PATCH] mm,shmem: Fix a typo in shmem_swapin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQkwBdpWTPjv4xIx@casper.infradead.org>
Date:   Tue, 3 Aug 2021 13:01:09 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     "Huang, Ying" <ying.huang@...el.com>
Cc:     Hugh Dickins <hughd@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Yang Shi <shy828301@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Miaohe Lin <linmiaohe@...wei.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...e.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Minchan Kim <minchan@...nel.org>
Subject: Re: [PATCH] mm,shmem: Fix a typo in shmem_swapin_page()

On Tue, Aug 03, 2021 at 04:14:38PM +0800, Huang, Ying wrote:
> Matthew Wilcox <willy@...radead.org> writes:
> > But I REALLY REALLY REALLY want a reproducer.  Right now, I have a hard
> > time believing this, or any of the other races can really happen.
> 
> I think the race is only theoretical too.  Firstly, swapoff is a rare
> operations in practice; secondly, the race window is really small.

So do something to provoke it.  Widen the window.  Put an msleep(1000)
between *pagep = NULL and the call to get_swap_device().  That's assuming
that the swapon/swapoff loop that I proposed doesn't work.  Did you
try it?