linux-kernel - Re: commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Aug 2021 14:39:30 +0200
From:   Fabio Aiuto <fabioaiuto83@...il.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     gregkh@...uxfoundation.org, hdegoede@...hat.com,
        Larry.Finger@...inger.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf_free()
 function")

Hi Fabio,

On Tue, Aug 03, 2021 at 02:23:25PM +0200, Fabio M. De Francesco wrote:
> On Tuesday, August 3, 2021 9:21:30 AM CEST Fabio Aiuto wrote:
> > 
> > Do you have any idea of what happened? This
> > topic could give us all deeper understanding
> > of kernel memory management.
> > 
> Hi Fabio,
> 
> I've just briefly looked at that c7e88ecbe328. I have no time to dig it deeper 
> but at a first look it seems that the following line is the culprit:
> 
> kfree(&pmlmepriv->assoc_req);
> 
> It should be:
> 
> kfree(pmlmepriv->assoc_req);

I think you are right :)

I didn't noticed rtw_buf_free's first argument is
a double star pointer.

> 
> The second line frees the memory location whose address is saved in assoc_rec; 
> the first line instead frees assoc_req itself.
> 
> Regards,
> 
> Fabio 
> 
> 
> 

thank you,

fabio