linux-kernel - Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210803140140.GM25548@kadam>
Date:   Tue, 3 Aug 2021 17:01:40 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix different base types in
 assignments and parameters

1) I'm pretty sure after a little more review that the patch introduces
   bugs.  The data is supposed to be big endian.

2) The commit message did not clearly describe the "bug" and how the it
   looks like to the user.

3) The way we set variables to zero is we say "foo = 0;"  We do not
   say "foo ^= foo;".  Everyone knows the XOR a variable with itself
   trick but obfuscated code makes us cross.

4) The unions were unnecessary and ugly/bad.

regards,
dan carpenter