linux-kernel - Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 03 Aug 2021 16:05:43 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] ALSA: usb-audio: make array static const, makes object smaller

On Tue, 03 Aug 2021 14:28:39 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate array names_to_check on the stack but instead it
> static.  Makes the object code smaller by 56 bytes.  Also clean
> up checkpatch warning by adding extra const for names_to_check
> and pointer s.
> 
> Before:
>     text    data     bss     dec     hex filename
>   103512   34380       0  137892   21aa4 ./sound/usb/mixer.o
> 
> After:
>     text    data     bss     dec     hex filename
>   103264   34572       0  137836   21a6c ./sound/usb/mixer.o
> 
> (gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> 
> V2: Clean up checkpatch warning on const-ness for names_to_check.
>     Add extra const to clean up build warning on pointer s.

Thanks, applied.


Takashi