linux-kernel - Re: [PATCH 0/2] Fix /proc/sys/fs/nfs/nsm_use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210803140846.GB30327@fieldses.org>
Date:   Tue, 3 Aug 2021 10:08:46 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Thomas Huth <thuth@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-nfs@...r.kernel.org, Chuck Lever <chuck.lever@...cle.com>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna.schumaker@...app.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>, linux-s390@...r.kernel.org,
        Jia He <hejianet@...il.com>,
        Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
Subject: Re: [PATCH 0/2] Fix /proc/sys/fs/nfs/nsm_use_hostnames on big endian
 machines

Looks good to me.  Could Chuck take it with nfsd stuff if somebody could
ACK the sysctl part?

--b.

On Tue, Aug 03, 2021 at 12:59:35PM +0200, Thomas Huth wrote:
> There is an endianess problem with /proc/sys/fs/nfs/nsm_use_hostnames
> (which can e.g. be seen on an s390x host) :
> 
>  # modprobe lockd nsm_use_hostnames=1
>  # cat /proc/sys/fs/nfs/nsm_use_hostnames
>  16777216
> 
> The nsm_use_hostnames variable is declared as "bool" which is required
> for the correct type for the module parameter. However, this does not
> work correctly with the entry in the /proc filesystem since this
> currently requires "int".
> 
> Jia He already provided patches for this problem a couple of years ago,
> but apparently they felt through the cracks and never got merged. So
> here's a rebased version to finally fix this issue.
> 
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1764075
> 
> Jia He (2):
>   sysctl: introduce new proc handler proc_dobool
>   lockd: change the proc_handler for nsm_use_hostnames
> 
>  fs/lockd/svc.c         |  2 +-
>  include/linux/sysctl.h |  2 ++
>  kernel/sysctl.c        | 42 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 45 insertions(+), 1 deletion(-)
> 
> -- 
> 2.27.0