linux-kernel - Re: [PATCH 16/38] sgi-xpc: Replace deprecated CPU-hotplug functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQlmwEmM9LS+RfNj@swahl-home.5wahls.com>
Date:   Tue, 3 Aug 2021 10:54:40 -0500
From:   Steve Wahl <steve.wahl@....com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        Peter Zijlstra <peterz@...radead.org>,
        Robin Holt <robinmholt@...il.com>,
        Steve Wahl <steve.wahl@....com>,
        Mike Travis <mike.travis@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 16/38] sgi-xpc: Replace deprecated CPU-hotplug functions.

Reviewed-by: Steve Wahl <steve.wahl@....com>

On Tue, Aug 03, 2021 at 04:15:59PM +0200, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been
> deprecated during the CPU hotplug rework. They map directly to
> cpus_read_lock() and cpus_read_unlock().
> 
> Replace deprecated CPU-hotplug functions with the official version.
> The behavior remains unchanged.
> 
> Cc: Robin Holt <robinmholt@...il.com>
> Cc: Steve Wahl <steve.wahl@....com>
> Cc: Mike Travis <mike.travis@....com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/misc/sgi-xp/xpc_uv.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
> index 7791bde81a368..ba9ae0e2df0fe 100644
> --- a/drivers/misc/sgi-xp/xpc_uv.c
> +++ b/drivers/misc/sgi-xp/xpc_uv.c
> @@ -1742,7 +1742,7 @@ xpc_init_mq_node(int nid)
>  {
>  	int cpu;
>  
> -	get_online_cpus();
> +	cpus_read_lock();
>  
>  	for_each_cpu(cpu, cpumask_of_node(nid)) {
>  		xpc_activate_mq_uv =
> @@ -1753,7 +1753,7 @@ xpc_init_mq_node(int nid)
>  			break;
>  	}
>  	if (IS_ERR(xpc_activate_mq_uv)) {
> -		put_online_cpus();
> +		cpus_read_unlock();
>  		return PTR_ERR(xpc_activate_mq_uv);
>  	}
>  
> @@ -1767,11 +1767,11 @@ xpc_init_mq_node(int nid)
>  	}
>  	if (IS_ERR(xpc_notify_mq_uv)) {
>  		xpc_destroy_gru_mq_uv(xpc_activate_mq_uv);
> -		put_online_cpus();
> +		cpus_read_unlock();
>  		return PTR_ERR(xpc_notify_mq_uv);
>  	}
>  
> -	put_online_cpus();
> +	cpus_read_unlock();
>  	return 0;
>  }
>  
> -- 
> 2.32.0
> 

-- 
Steve Wahl, Hewlett Packard Enterprise