linux-kernel - Re: [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute after sensors are found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPUE2utqRi9+Rb3UPE6FFRVoKDE5z+NFk1TL5Nmb7CW-VpBK=A@mail.gmail.com>
Date:   Wed, 4 Aug 2021 14:09:37 -0700
From:   Gwendal Grignou <gwendal@...omium.org>
To:     Dmitry Torokhov <dtor@...omium.org>
Cc:     Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Gwendal Grignou <gwendal@...gle.com>
Subject: Re: [PATCH v2 0/2] platform/chrome: Update cros_ec sysfs attribute
 after sensors are found

The v2 patches I submitted were wrong, as cros_ec sysfs driver is
modifying the attributes of the class driver, not its own. I repost a
patch that takes that into account.
Gwendal.

On Sun, May 30, 2021 at 10:36 PM Dmitry Torokhov <dtor@...omium.org> wrote:
>
> Hi Gwendal,
>
> On Thu, May 27, 2021 at 2:01 PM Gwendal Grignou <gwendal@...omium.org> wrote:
> >
> > [+dtor]
> > Is this change acceptable? I was worried it could break when
> > asynchronous probing is used [https://lwn.net/Articles/629895/], but
> > since all probes are deferred in a single thread, it is safe.
>
> I think this is a bit awkward that we need to poke a separate sub-driver.
>
> Have you considered having cros_ec_sensorhub.c create its own
> attribute group (it does not have to have a name and it looks like one
> can register as many unnamed groups as they want) and have wake angle
> show and store methods directly in cros_ec_sensorhub.c?
>
> Thanks,
> Dmitry