linux-kernel - Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f28fe6e-a8ce-e444-51db-d0eb564eca8f@linux.intel.com>
Date:   Wed, 4 Aug 2021 15:26:15 -0700
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter H Anvin <hpa@...or.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX
 guest



On 8/4/21 3:03 PM, Dave Hansen wrote:
>>> +#include <asm/processor.h>
>>> +#include <asm/tdx.h>
>>> +
>>>   #ifndef __ASSEMBLY__
>>>   
>>>   static inline bool prot_guest_has(unsigned int attr)
>>>   {
>>>   	if (sme_me_mask)
>>>   		return amd_prot_guest_has(attr);
>>> +	else if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
>> Why not "boot_cpu_has(X86_FEATURE_TDX_GUEST)"?
> Even better: cpu_feature_enabled(X86_FEATURE_TDX_GUEST).  That gets you
> both static patching*and*  compile-time optimization if you hook
> X86_FEATURE_TDX_GUEST into disabled-features.h.

This is how Borislav preferred it. tdx_prot_guest_has() internally uses
cpu_feature_enabled(X86_FEATURE_TDX_GUEST) to return the status.

I think the intention is to keep the first call generic (non TDX
specific). So that it can be extended for other use cases.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer