linux-kernel - Re: [PATCH v1 1/3] dmaengine: dw: Remove error message from DT parsing code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210804094607.ac3zxomlmu3ifpqr@mobilestation>
Date:   Wed, 4 Aug 2021 12:46:07 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        Viresh Kumar <vireshk@...nel.org>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v1 1/3] dmaengine: dw: Remove error message from DT
 parsing code

Hello Andy

On Mon, Aug 02, 2021 at 09:43:53PM +0300, Andy Shevchenko wrote:
> Users are a bit frightened of the harmless message that tells that
> DT is missed on ACPI-based platforms. Remove it for good, it will
> simplify the future conversion to fwnode and device property APIs.

Thanks for the cleanup patchset. No comments from me, just the tags
for the whole series:
Reviewed-by: Serge Semin <fancer.lancer@...il.com>
Tested-by: Serge Semin <fancer.lancer@...il.com>
[Tested on Baikal-T1 DW DMAC with 8 channels, 12 requests, 2 masters,
no multi-block support and uneven max burst length setup]

-Sergey

> 
> Fixes: a9ddb575d6d6 ("dmaengine: dw_dmac: Enhance device tree support")
> Depends-on: f5e84eae7956 ("dmaengine: dw: platform: Split OF helpers to separate module")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199379
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/dw/of.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/dw/of.c b/drivers/dma/dw/of.c
> index c1cf7675b9d1..4d2b89142721 100644
> --- a/drivers/dma/dw/of.c
> +++ b/drivers/dma/dw/of.c
> @@ -54,11 +54,6 @@ struct dw_dma_platform_data *dw_dma_parse_dt(struct platform_device *pdev)
>  	u32 nr_masters;
>  	u32 nr_channels;
>  
> -	if (!np) {
> -		dev_err(&pdev->dev, "Missing DT data\n");
> -		return NULL;
> -	}
> -
>  	if (of_property_read_u32(np, "dma-masters", &nr_masters))
>  		return NULL;
>  	if (nr_masters < 1 || nr_masters > DW_DMA_MAX_NR_MASTERS)
> -- 
> 2.30.2
>