linux-kernel - Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 04 Aug 2021 13:29:31 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters

On Wednesday, August 4, 2021 11:58:39 AM CEST Dan Carpenter wrote:
> The patch was based on the faulty premise that the original code was
> buggy so I don't think it can be fixed.  It just needs to be reverted.
> 
> regards,
> dan carpenter

With the original code, GCC + sparse emit a dozen of warnings like the 
following ones:

drivers/staging/r8188eu/core/rtw_br_ext.c:693:101: warning: incorrect type in 
argument 2 (different base types)
drivers/staging/r8188eu/core/rtw_br_ext.c:693:101:    expected unsigned int 
*ipxNetAddr
drivers/staging/r8188eu/core/rtw_br_ext.c:693:101:    got restricted __be32 *
drivers/staging/r8188eu/core/rtw_br_ext.c:693:123: warning: incorrect type in 
argument 3 (different base types)
drivers/staging/r8188eu/core/rtw_br_ext.c:693:123:    expected unsigned short 
*ipxSocketAddr
drivers/staging/r8188eu/core/rtw_br_ext.c:693:123:    got restricted __be16 *
drivers/staging/r8188eu/core/rtw_br_ext.c:698:99: warning: incorrect type in 
argument 2 (different base types)

Do we want the above pasted warnings and leave the code as-is?

Regards,

Fabio