linux-kernel - Re: [PATCH v2] tablet: acecad: update the reference count of the usb interface structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Aug 2021 14:03:00 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Salah Triki <salah.triki@...il.com>,
        Fabio Aiuto <fabioaiuto83@...il.com>,
        Ross Schmidt <ross.schm.dev@...il.com>,
        Marco Cesati <marcocesati@...il.com>,
        Brother Matthew De Angelis <matthew.v.deangelis@...il.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Ivan Safonov <insafonov@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] tablet: acecad: update the reference count of the usb
 interface structure

On Wed, Aug 04, 2021 at 01:58:38PM +0300, Dan Carpenter wrote:
> On Sat, Jul 31, 2021 at 05:09:38PM +0100, Salah Triki wrote:
> >  drivers/input/tablet/acecad.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
> > index a38d1fe97334..85fe134a30ee 100644
> > --- a/drivers/input/tablet/acecad.c
> > +++ b/drivers/input/tablet/acecad.c
> > @@ -151,7 +151,7 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
> >  		goto fail2;
> >  	}
> >  
> > -	acecad->intf = intf;
> > +	acecad->intf = usb_get_intf(intf);
> >  	acecad->input = input_dev;
> >  
> >  	if (dev->manufacturer)
> 
> As I mentioned earlier, you need to drop the reference if
> input_register_device() fails.

Also as mentioned in other threads, this is not needed at all.