linux-kernel - Re: [PATCH 1/6] staging: r8188eu: Remove wrappers for kalloc() and kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210804131550.GL1931@kadam>
Date:   Wed, 4 Aug 2021 16:15:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     gregkh@...uxfoundation.org, phil@...lpotter.co.uk,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging: r8188eu: Remove wrappers for kalloc() and
 kzalloc()

On Mon, Aug 02, 2021 at 10:15:41AM -0500, Larry Finger wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c.rej b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
> new file mode 100644
> index 000000000000..18113389acce
> --- /dev/null
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c.rej
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

;)  Something went wrong.

(I'm not going to review the rest of this series.)

> @@ -0,0 +1,11 @@
> +--- drivers/staging/r8188eu/core/rtw_br_ext.c
> ++++ drivers/staging/r8188eu/core/rtw_br_ext.c
> +@@ -420,7 +420,7 @@ static void __nat25_db_network_insert(st
> + 		}
> + 		db = db->next_hash;
> + 	}
> +-	db = (struct nat25_network_db_entry *) rtw_malloc(sizeof(*db));
> ++	db = kmalloc(sizeof(*db), GFP_KERNEL);
> + 	if (db == NULL) {
> + 		spin_unlock_bh(&priv->br_ext_lock);
> + 		return;

regards,
dan carpenter