linux-kernel - Re: [PATCH 1/2] staging: r8188eu: remove RT_TRACE and DBG_88E prints from usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Aug 2021 16:13:13 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: r8188eu: remove RT_TRACE and DBG_88E prints
 from usb_intf.c

Thus wrote Dan Carpenter (dan.carpenter@...cle.com):

> On Sun, Aug 01, 2021 at 07:30:22PM +0200, Martin Kaiser wrote:
> >  #endif

> > -	/* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto
> > -	 * suspend influence */
> > -	if (usb_autopm_get_interface(pusb_intf) < 0)
> > -			DBG_88E("can't get autopm:\n");
> > -
> >  	/*  alloc dev name after read efuse. */
> >  	rtw_init_netdev_name(pnetdev, padapter->registrypriv.ifname);
> >  	rtw_macaddr_cfg(padapter->eeprompriv.mac_addr);

> This patch accidentally removes the usb_autopm_get_interface() call.

Thanks, I didn't notice this. Just sent out v2.