linux-kernel - Re: [PATCH V3 1/5] ext4: remove the 'group' parameter of ext4_trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210804152658.GH4578@quack2.suse.cz>
Date:   Wed, 4 Aug 2021 17:26:58 +0200
From:   Jan Kara <jack@...e.cz>
To:     Wang Jianchao <jianchao.wan9@...il.com>
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        tytso@....edu, adilger.kernel@...ger.ca
Subject: Re: [PATCH V3 1/5] ext4: remove the 'group' parameter of
 ext4_trim_extent

On Sat 24-07-21 15:41:20, Wang Jianchao wrote:
> From: Wang Jianchao <wangjianchao@...ishou.com>
> 
> Get rid of the 'group' parameter of ext4_trim_extent as we can get
> it from the 'e4b'.
> 
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> Signed-off-by: Wang Jianchao <wangjianchao@...ishou.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/mballoc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 089c958aa2c3..018d5d3c6eeb 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -6183,19 +6183,19 @@ int ext4_group_add_blocks(handle_t *handle, struct super_block *sb,
>   * @sb:		super block for the file system
>   * @start:	starting block of the free extent in the alloc. group
>   * @count:	number of blocks to TRIM
> - * @group:	alloc. group we are working with
>   * @e4b:	ext4 buddy for the group
>   *
>   * Trim "count" blocks starting at "start" in the "group". To assure that no
>   * one will allocate those blocks, mark it as used in buddy bitmap. This must
>   * be called with under the group lock.
>   */
> -static int ext4_trim_extent(struct super_block *sb, int start, int count,
> -			     ext4_group_t group, struct ext4_buddy *e4b)
> +static int ext4_trim_extent(struct super_block *sb,
> +		int start, int count, struct ext4_buddy *e4b)
>  __releases(bitlock)
>  __acquires(bitlock)
>  {
>  	struct ext4_free_extent ex;
> +	ext4_group_t group = e4b->bd_group;
>  	int ret = 0;
>  
>  	trace_ext4_trim_extent(sb, group, start, count);
> @@ -6271,8 +6271,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
>  		next = mb_find_next_bit(bitmap, max + 1, start);
>  
>  		if ((next - start) >= minblocks) {
> -			ret = ext4_trim_extent(sb, start,
> -					       next - start, group, &e4b);
> +			ret = ext4_trim_extent(sb, start, next - start, &e4b);
>  			if (ret && ret != -EOPNOTSUPP)
>  				break;
>  			ret = 0;
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR