linux-kernel - Re: [ANNOUNCE] v5.14-rc4-rt4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210804162231.rfj5i736lqc4nsio@linutronix.de>
Date:   Wed, 4 Aug 2021 18:22:31 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Peter Zijlstra <peterz@...radead.org>,
        Daniel Wagner <wagi@...om.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-rt-users@...r.kernel.org
Subject: Re: [ANNOUNCE] v5.14-rc4-rt4

On 2021-08-04 12:17:04 [-0400], Steven Rostedt wrote:
> Perhaps in this situation, we could open code it to:
> 
>   	if (stall_hash != -1U) {
> 		raw_spin_unlock(&wqe->lock);
> 
> 		/* On RT the spin_lock_irq() does not disable interrupts */
> 		if (IS_ENABLED(CONFIG_PREEMPT_RT))
> 			local_irq_enable();

no preemption happens here with NEED_RESCHED set.

>  		io_wait_on_hash(wqe, stall_hash);
> 
> 		if (IS_ENABLED(CONFIG_PREEMPT_RT))
> 			local_irq_disable();
> 		raw_spin_lock(&wqe->lock);
>  	}
> 
> Note, I haven't looked at the rest of the code to know the ripple
> effect of this, but I'm just suggesting the idea.
> 

Sebastian