linux-kernel - Re: [PATCH] libkmod-module: add support for a patient module removal option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQrVY8Wxb026TDWN@bombadil.infradead.org>
Date:   Wed, 4 Aug 2021 10:58:59 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     lucas.demarchi@...el.com, linux-modules@...r.kernel.org
Cc:     live-patching@...r.kernel.org, fstests@...r.kernel.org,
        linux-block@...r.kernel.org, hare@...e.de, dgilbert@...erlog.com,
        jeyu@...nel.org, osandov@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libkmod-module: add support for a patient module removal
 option

On Tue, Aug 03, 2021 at 01:24:17PM -0700, Luis Chamberlain wrote:
> + diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
<-- snip -->
> +		ERR(mod->ctx, "%s refcnt is %ld waiting for it to become 0\n", mod->name, refcnt);

OK after running many tests with this I think we need to just expand
this so that the error message only applies when -v is passed to
modprobe, otherwise we get the print message every time, and using
INFO() doesn't cut it, given the next priority level available to
the library is LOG_INFO (6) and when modprobe -v is passed we set the
log level to LOG_NOTICE (5), so we need a new NOTICE(). I'll send a v2
with that included as a separate patch.

  Luis