linux-kernel - Re: [PATCH] staging: r8188eu: core: Remove rtw_mfree_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <406c6f84-a2f6-1a0e-3a52-9406df41973c@lwfinger.net>
Date:   Wed, 4 Aug 2021 13:10:37 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: core: Remove rtw_mfree_all_stainfo()

On 8/4/21 10:09 AM, Larry Finger wrote:
> In other Realtek drivers, the while loop has a call to rtw_mfree_stainfo(psta). 
> That routine does not exist in this driver, but I think it should. In a few rare 
> instances, the driver leaks some memory - this missing code may explain that. In 
> any case, this patch should be dropped as the fix will require testing.

After looking at the original code for several other drivers, routine 
rtw_mfree_stainfo() just ends up calling a couple of routines that free a 
spinlock. That operation for Windows and FreeBSD is not trivial, but for Linux, 
the routine does nothing. Thus, despite its name, rtw_mfree_stainfo() does not 
free anything, and it can be deleted.

The original patch is

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry