linux-kernel - Re: [PATCH v1] driver: base: Add driver filter support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515ff3e6-d7aa-4d40-1cf7-7113721d68b9@linux.intel.com>
Date:   Wed, 4 Aug 2021 12:27:44 -0700
From:   Andi Kleen <ak@...ux.intel.com>
To:     "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Dan Williams <dan.j.williams@...el.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v1] driver: base: Add driver filter support


On 8/4/2021 11:29 AM, Kuppuswamy, Sathyanarayanan wrote:
>
>
> On 8/4/21 11:08 AM, Matthew Wilcox wrote:
>> Why use a doubly-linked-list here?  An allocating xarray should perform
>> much better and use less memory.
>
> We don't expect the list to be too long. So we may not gain any 
> significant
> advantage in terms of performance or memory when using alternate 
> lists. Since
> linked list easier to use, we chose it.
>
Also even if it was long it wouldn't matter because this isn't a fast 
path at all.

All that matters it to write the code as clearly as possible.

-Andi