linux-kernel - Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_PcfoQijtu86BKDjGNEE3JxmsrvigMaO_mBrWQrBtmR3Q@mail.gmail.com>
Date:   Thu, 5 Aug 2021 15:40:50 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <ckoenig.leichtzumerken@...il.com>
Cc:     Sergio Miguéns Iglesias <lonyelon@...il.com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        xinhui pan <Xinhui.Pan@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergio Miguéns Iglesias <sergio@...y.xyz>
Subject: Re: [PATCH] DRM: gpu: radeon: Fixed coding style issues

Applied.  Thanks!

Alex

On Thu, Aug 5, 2021 at 8:33 AM Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
>
> Am 04.08.21 um 13:20 schrieb Sergio Miguéns Iglesias:
> > Fixed braces, an unnecessary if statement and added a missing space.
> >
> > Signed-off-by: Sergio Miguéns Iglesias <sergio@...y.xyz>
>
> Normally we see patches which just fixes coding style as unnecessary
> churn, but the "if (rbo) {}" is really ugly here.
>
> So Reviewed-by: Christian König <christian.koenig@....com>.
>
> Thanks,
> Christian.
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_fb.c | 7 ++-----
> >   1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> > index 0b206b052972..6640b7c947fe 100644
> > --- a/drivers/gpu/drm/radeon/radeon_fb.c
> > +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> > @@ -54,6 +54,7 @@ radeonfb_open(struct fb_info *info, int user)
> >       struct radeon_fbdev *rfbdev = info->par;
> >       struct radeon_device *rdev = rfbdev->rdev;
> >       int ret = pm_runtime_get_sync(rdev->ddev->dev);
> > +
> >       if (ret < 0 && ret != -EACCES) {
> >               pm_runtime_mark_last_busy(rdev->ddev->dev);
> >               pm_runtime_put_autosuspend(rdev->ddev->dev);
> > @@ -196,9 +197,8 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> >               radeon_bo_check_tiling(rbo, 0, 0);
> >       ret = radeon_bo_kmap(rbo, NULL);
> >       radeon_bo_unreserve(rbo);
> > -     if (ret) {
> > +     if (ret)
> >               goto out_unref;
> > -     }
> >
> >       *gobj_p = gobj;
> >       return 0;
> > @@ -294,9 +294,6 @@ static int radeonfb_create(struct drm_fb_helper *helper,
> >       return 0;
> >
> >   out:
> > -     if (rbo) {
> > -
> > -     }
> >       if (fb && ret) {
> >               drm_gem_object_put(gobj);
> >               drm_framebuffer_unregister_private(fb);
>