linux-kernel - Re: [gustavoars-linux:for-next/clang-fallthrough 1/1] warning: fallthrough annotation in unreachable code/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Aug 2021 16:52:23 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Nathan Chancellor <nathan@...nel.org>,
        kernel test robot <lkp@...el.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        clang-built-linux@...glegroups.com, kbuild-all@...ts.01.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [gustavoars-linux:for-next/clang-fallthrough 1/1] warning:
 fallthrough annotation in unreachable code/



On 8/5/21 14:04, Nathan Chancellor wrote:
> On Thu, Aug 05, 2021 at 02:21:34PM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git for-next/clang-fallthrough
>> head:   58d0d2d2e7dc1b1a4997bb9c47d6cf428f2d3a00
>> commit: 58d0d2d2e7dc1b1a4997bb9c47d6cf428f2d3a00 [1/1] Revert "Revert "Makefile: Enable -Wimplicit-fallthrough for Clang""
>> config: hexagon-randconfig-r023-20210804 (attached as .config)
>> compiler: clang version 12.0.0
>> reproduce (this is a W=1 build):
>>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=58d0d2d2e7dc1b1a4997bb9c47d6cf428f2d3a00
>>         git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
>>         git fetch --no-tags gustavoars-linux for-next/clang-fallthrough
>>         git checkout 58d0d2d2e7dc1b1a4997bb9c47d6cf428f2d3a00
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon 
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@...el.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
>>>> warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
>>    2 warnings generated.
> 
> With a newer version of clang that shows proper line numbers:

Yep; I've been using mainline since you told us about commit
	
	1b4800c26259 ("[clang][parser] Set source ranges for GNU-style attributes")

:)

> Which is already being tracked: https://github.com/ClangBuiltLinux/linux/issues/1429

Hopefully, this will be solved soon: https://bugs.llvm.org/show_bug.cgi?id=51094 (fingers crossed).

Thanks
--
Gustavo