linux-kernel - RE: [PATCH v7 0/5] make '%pD' print the full path of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB4376B0A9A230C3C71AC97F40F7F29@AM6PR08MB4376.eurprd08.prod.outlook.com>
Date:   Thu, 5 Aug 2021 00:39:30 +0000
From:   Justin He <Justin.He@....com>
To:     Alexander Viro <viro@...iv.linux.org.uk>
CC:     Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Eric Biggers <ebiggers@...gle.com>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Christoph Hellwig <hch@...radead.org>, nd <nd@....com>
Subject: RE: [PATCH v7 0/5] make '%pD' print the full path of file

Hi Al

> -----Original Message-----
> From: Petr Mladek <pmladek@...e.com>
> Sent: Wednesday, July 21, 2021 10:12 PM
> To: Justin He <Justin.He@....com>; Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Steven Rostedt <rostedt@...dmis.org>; Sergey Senozhatsky
> <senozhatsky@...omium.org>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; Rasmus Villemoes
> <linux@...musvillemoes.dk>; Jonathan Corbet <corbet@....net>; Linus
> Torvalds <torvalds@...ux-foundation.org>; Peter Zijlstra (Intel)
> <peterz@...radead.org>; Eric Biggers <ebiggers@...gle.com>; Ahmed S.
> Darwish <a.darwish@...utronix.de>; linux-doc@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org; Matthew Wilcox
> <willy@...radead.org>; Christoph Hellwig <hch@...radead.org>; nd
> <nd@....com>
> Subject: Re: [PATCH v7 0/5] make '%pD' print the full path of file
> 
> On Thu 2021-07-15 09:14:02, Jia He wrote:
> > Background
> > ==========
> > Linus suggested printing the full path of file instead of printing
> > the components as '%pd'.
> >
> > Typically, there is no need for printk specifiers to take any real locks
> > (ie mount_lock or rename_lock). So I introduce a new helper
> > d_path_unsafe() which is similar to d_path() except it doesn't take any
> > seqlock/spinlock.
> >
> > TODO
> > ====
> > I plan to do the followup work after '%pD' behavior is changed.
> > - s390/hmcdrv: remove the redundant directory path in printing string.
> > - fs/iomap: simplify the iomap_swapfile_fail() with '%pD'.
> > - simplify the string printing when file_path() is invoked(in some
> >   cases, not all).
> > - change the previous '%pD[2,3,4]' to '%pD'
> >
> > Jia He (4):
> >   d_path: fix Kernel doc validator complaints
> >   d_path: introduce helper d_path_unsafe()
> >   lib/vsprintf.c: make '%pD' print the full path of file
> >   lib/test_printf.c: add test cases for '%pD'
> >
> > Rasmus Villemoes (1):
> >   lib/test_printf.c: split write-beyond-buffer check in two
> 
> The patchset is ready for linux-next from my POV.
> 
> I could take it via printk tree if Al provides Acks for the
> first two "d_path: *: patches.
> 
> Or Al could take it via his tree if he would prefer to do so.

Kindly ping 😉

--
Cheers,
Justin (Jia He)