[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1628140993.20108.4.camel@mbjsdccf07>
Date: Thu, 5 Aug 2021 13:23:13 +0800
From: Mason Zhang <mason.zhang@...iatek.com>
To: Mark Brown <broonie@...nel.org>
CC: Matthias Brugger <matthias.bgg@...il.com>,
Laxman Dewangan <ldewangan@...dia.com>,
<linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>, <wsd_upstream@...iatek.com>,
<mason.zhang@...iatek.com>
Subject: Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param
On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> >
> > Signed-off-by: Mason Zhang <Mason.Zhang@...iatek.com>
> > ---
> > drivers/spi/spi-tegra114.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen. This supports
> things like bisection.
>
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.
Dear Mark:
Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
And I have updated the patch v3, and removed the *** int the first
patch.
Thanks
Mason
Powered by blists - more mailing lists