linux-kernel - RE: [PATCH v1 2/2] scsi: ufs: Add lu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB657589C9EE72DD8B4F62C6BDFCF29@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Thu, 5 Aug 2021 06:35:44 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Bean Huo <huobean@...il.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "daejun7.park@...sung.com" <daejun7.park@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 2/2] scsi: ufs: Add lu_enable sysfs node

> From: Bean Huo <beanhuo@...ron.com>
> 
> We need to check HPB being enabled on which LU from the userspace tool,
> so, add lu_enable sysfs node.
> 
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
Reviewed-by: Avri Altman <avri.altman@....com>
Tested-by: Avri Altman <avri.altman@....com>

> ---
>  drivers/scsi/ufs/ufs-sysfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c
> index 08fe037069bc..5c405ff7b6ea 100644
> --- a/drivers/scsi/ufs/ufs-sysfs.c
> +++ b/drivers/scsi/ufs/ufs-sysfs.c
> @@ -1163,6 +1163,7 @@ static DEVICE_ATTR_RO(_pname)
>  #define UFS_UNIT_DESC_PARAM(_name, _uname, _size)                      \
>         UFS_LUN_DESC_PARAM(_name, _uname, UNIT, _size)
> 
> +UFS_UNIT_DESC_PARAM(lu_enable, _LU_ENABLE, 1);
>  UFS_UNIT_DESC_PARAM(boot_lun_id, _BOOT_LUN_ID, 1);
>  UFS_UNIT_DESC_PARAM(lun_write_protect, _LU_WR_PROTECT, 1);
>  UFS_UNIT_DESC_PARAM(lun_queue_depth, _LU_Q_DEPTH, 1);
> @@ -1181,8 +1182,8 @@
> UFS_UNIT_DESC_PARAM(hpb_pinned_region_start_offset,
> _HPB_PIN_RGN_START_OFF, 2);
>  UFS_UNIT_DESC_PARAM(hpb_number_pinned_regions,
> _HPB_NUM_PIN_RGNS, 2);
>  UFS_UNIT_DESC_PARAM(wb_buf_alloc_units, _WB_BUF_ALLOC_UNITS, 4);
> 
> -
>  static struct attribute *ufs_sysfs_unit_descriptor[] = {
> +       &dev_attr_lu_enable.attr,
>         &dev_attr_boot_lun_id.attr,
>         &dev_attr_lun_write_protect.attr,
>         &dev_attr_lun_queue_depth.attr,
> --
> 2.25.1