linux-kernel - Re: [PATCH v2] Bluetooth: Shutdown controller after workqueues are flushed or cancelled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAJMQK-ifNH7hoU-U3EzzrvqBOSG1fq9t=xvq8ry24zJXKPfNVA@mail.gmail.com>
Date:   Thu, 5 Aug 2021 15:04:09 +0800
From:   Hsin-Yi Wang <hsinyi@...omium.org>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Mattijs Korpershoek <mkorpershoek@...libre.com>,
        Bluez <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Bluetooth: Shutdown controller after workqueues are
 flushed or cancelled

On Thu, Aug 5, 2021 at 3:01 PM Hillf Danton <hdanton@...a.com> wrote:
>
> On Thu, 5 Aug 2021 14:12:10 +0800 Hsin-Yi Wang wrote:
> >
> >The original patch 60789afc02f592b8d91217b60930e7a76271ae07
> >("Bluetooth: Shutdown controller after workqueues are flushed or
> >cancelled") is causing the tx fail when downloading fw on mediatek
> >mt8183 device using QCA bluetooth:
>
> Want to know if reverting 60789afc02f59 is a cure.

Reverting 60789afc02f592b8d91217b60930e7a76271ae07 can also fixed the issue.
>
> >
> >[  225.205061] Bluetooth: qca_download_firmware() hci0: QCA
> >Downloading qca/rampatch_00440302.bin
> >[  227.252653] Bluetooth: hci_cmd_timeout() hci0: command 0xfc00 tx timeout
> >...
> >follows by a lot of:
> >[  223.604971] Bluetooth: qca_recv() hci0: Frame reassembly failed (-84)
> >[  223.605027] Bluetooth: qca_recv() hci0: Frame reassembly failed (-84)
> >
> >After applying the fixup to allow tx, the issue is solved.
>
> Feel free to specify the fixup and its link to 60789afc02f59.

The fixup is pasted by Kai-Heng here:
https://lkml.org/lkml/2021/8/3/103