linux-kernel - Re: [PATCH v2 2/2] Revert "media: device property: Call fwnode_graph_get_endpoint_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YQujbIj0ynE43vw9@kroah.com>
Date:   Thu, 5 Aug 2021 10:38:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Daniel Scally <djrscally@...il.com>
Cc:     linux-kernel@...r.kernel.org, rafael@...nel.org,
        andriy.shevchenko@...ux.intel.com,
        laurent.pinchart@...asonboard.com
Subject: Re: [PATCH v2 2/2] Revert "media: device property: Call
 fwnode_graph_get_endpoint_by_id() for fwnode->secondary"

On Thu, Aug 05, 2021 at 12:03:13AM +0100, Daniel Scally wrote:
> This reverts commit acd418bfcfc415cf5e6414b6d1c6acfec850f290. Checking for
> endpoints against fwnode->secondary in fwnode_graph_get_next_endpoint() is
> a better way to do this since that function is also used in a bunch of
> other places, for instance sensor drivers checking that they do have an
> endpoint connected during probe.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Daniel Scally <djrscally@...il.com>
> ---
>  drivers/base/property.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

This can only be reverted due to your 1/2 change, right?  If so, you
might want to make that explicit here...

thanks,

greg k-h