[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210805091218.GD5979@alpha.franken.de>
Date: Thu, 5 Aug 2021 11:12:18 +0200
From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Andy Lutomirski <luto@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Vincenzo Frascino <vincenzo.frascino@....com>,
linux-kernel@...r.kernel.org, Will Deacon <will@...nel.org>,
Palmer Dabbelt <palmer@...belt.com>,
Michael Ellerman <mpe@...erman.id.au>,
Catalin Marinas <catalin.marinas@....com>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Guo Ren <guoren@...nel.org>, linux-mips@...r.kernel.org,
Paul Mackerras <paulus@...ba.org>, linux-csky@...r.kernel.org,
linux-riscv@...ts.infradead.org, Albert Ou <aou@...s.berkeley.edu>,
linuxppc-dev@...ts.ozlabs.org,
Russell King <linux@...linux.org.uk>,
linux-arm-kernel@...ts.infradead.org,
Paul Walmsley <paul.walmsley@...ive.com>
Subject: Re: [PATCH v2] arch: vdso: remove if-conditionals of
$(c-gettimeofday-y)
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote:
> arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY,
> hence $(gettimeofday-y) never becomes empty.
>
> riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y,
> but arch/riscv/kernel/vdso/vgettimeofday.o is built only under that
> condition. So, you can always define CFLAGS_vgettimeofday.o
>
> Remove all the meaningless conditionals.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
> Changes in v2:
> - Fix csky as well
>
> [..]
> arch/mips/vdso/Makefile | 2 --
Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists