linux-kernel - [tip: sched/core] sched: remove redundant on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <162815607635.395.12214105489940284165.tip-bot2@tip-bot2>
Date:   Thu, 05 Aug 2021 09:34:36 -0000
From:   "tip-bot2 for Wang Hui" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Wang Hui <john.wanghui@...wei.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: sched/core] sched: remove redundant on_rq status change

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     f912d051619d11411867f642d2004928eb0b41b1
Gitweb:        https://git.kernel.org/tip/f912d051619d11411867f642d2004928eb0b41b1
Author:        Wang Hui <john.wanghui@...wei.com>
AuthorDate:    Wed, 21 Jul 2021 17:11:09 +08:00
Committer:     Peter Zijlstra <peterz@...radead.org>
CommitterDate: Wed, 04 Aug 2021 15:16:43 +02:00

sched: remove redundant on_rq status change

activate_task/deactivate_task will change on_rq status,
no need to do it again.

Signed-off-by: Wang Hui <john.wanghui@...wei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Link: https://lkml.kernel.org/r/20210721091109.1406043-1-john.wanghui@huawei.com
---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0c22cd0..6c562ad 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5659,11 +5659,9 @@ static bool try_steal_cookie(int this, int that)
 		if (p->core_occupation > dst->idle->core_occupation)
 			goto next;
 
-		p->on_rq = TASK_ON_RQ_MIGRATING;
 		deactivate_task(src, p, 0);
 		set_task_cpu(p, this);
 		activate_task(dst, p, 0);
-		p->on_rq = TASK_ON_RQ_QUEUED;
 
 		resched_curr(dst);